| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tui for ticket uses indexing in order to have quicker unchecked
access into data structures for the data needed that gets displayed in
the tui. However, you can't index empty data. We add a check for this in
places that expect data to exist so that nothing will cause a panic. We
also add fixes to handle the fact that you can't divide by zero in our
index modifying logic when pressing the left/right/up/down arrow keys.
With this the tui shouldn't panic anymore and can work in an empty
state.
Closes: 4c37e800-2e38-11ea-b6e0-32f54a3ad7cd 'Having no tickets causes
the TUI to crash'
|
| |
|
|
|
|
|
|
|
|
| |
In ticket 9b344c00-2e3d-11ea-bc2d-b4e1317c6ecc 'Create a panic handler
for ticket tui' it became clear that ticket needed it's own way to
handle panics since crashing the tui without cleaning up after itself
leaves the terminal in a completely garbled state. This commit now
has the tui clean up properly after itself then run the normal hook
which means it panics like any other Rust program and can get a
backtrace with the panic as usual with RUST_BACKTRACE=1
|
| |
|
|
|
|
|
|
|
|
|
| |
There was no variable expansion called for %PATH% in
setx PATH <dev-suite>;%PATH%
effectively replacing PATH with litteraly `<dev-suite>;%PATH%`.
The fix is simple, the command just needs to be called inside a shell
with `cmd /C`.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Up to this point hooked had been only designed to work on Windows, not
because dev-suite didn't want to support it, but because doing so was an
immense amount of work with no clear design due to how Unix and Window
paths are not at all the same. While shebang notation works on them for
both the paths are different.
In order to get around this we wrap Ruby, Python, and Bash scripts on
Windows with a different script that invokes the 'Git for Windows'
sh.exe to run the actual interpreters on the script. These can work fine
then as long as one has installed Git for Windows on their machine, and
has a copy of py.exe or ruby.exe on their path to be invoked.
There is one caveat. We have to assume that a user has installed their
copy of Git for Windows in the default location. This means if they
haven't the scripts will fail to run. There's not much we can do about
this and it's just a necessary wart to provide cross platform
capabilities for a project.
All projects can be initialized now with one of the language choices and
then have the proper files linked on their OS as part of the
initialization. Those who need to just link them in an already existing
project can just run `hooked link` in order to set their computer up.
This again handles the differences between the platforms. This project
is also updated to the new format of hooked so that collaboration is now
not limited to just Unix based OSes.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit encompasses quite a few changes to add tickets:
- The `Ticket` struct is updated to properly order comments using a uuid
v1 and to hold the user name, uuid, and their comment
- Tickets in the repo are updated to accomodate this change to the
ticket. Despite this being a breaking config change, none of these
tickets had any comments so it was an easy manual port and the
migration tool did not need to be updated.
- The TUI was updated to display the tickets a bit better with some
coloring and now also showing the comments with them
This gets us one step closer to a decent first release for ticket. The
only things that are really left to do are adding the ability to comment
in the tui, listing tickets on the cli, and adding in issue assignees on
both the cli and tui.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
This commit really ups the level and quality of the Rust code by setting
clippy to pedantic mode. It also fixes an issue where bash continued to
run scripts even if something failed with a non-zero exit status. We
also deny all warnings so as to actually fail the builds and the commit
hooks. This should make sure code quality stays at a high level.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a necessary upgrade to deal with the fact that incremental ids
do not work in distributed systems. For instance say we have two
branches from the same commit on master and they both add a new ticket.
Both will have the same incremental ID despite being completely separate
tickets. In this case we want to use UUIDs, specifically version 1 as
defined in IETF RFC 4122. This version of UUID uses a timestamp to
generate it and as a result the UUID it generates is *sortable*. This
means that the UUIDs can be created whenever on any branch, be unique,
and will be sortable by time. No matter when or where our tickets can be
sorted correctly by this UUID in a deterministic order.
Since we are also upgrading the code we've set up migration upgrade code
to handle this in case we need to do this again in the future. We also
add a few more fields and make some breaking changes since we already
are for the UUIDs.
Resources:
- https://tools.ietf.org/html/rfc4122
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
This adds a commit to handle git commit linting to enforce style by not
allowing less than 10 or more than 50 chars for titles and less than or
equal to 72 chars for the body. Chars are measured in number of
graphemes as 50 chars represented in the terminal is what we want to use
not 50 bytes. This will eventually be an installable hook for end users
if they want it.
|
| |
|
|
|
|
|
|
|
| |
This enables a pre-commit script and adding more pedantic checks to the
commit. This means from now on all commits will be in a working state in
the history and this enables us to build directly on master without
worrying about it breaking the build. Where we're going we won't need
feature branches anymore. This also fixes formatting issues that existed
but the GitHub actions would not be able to catch at all.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the hooked binary to the dev-suite repo as well as a stub for
a program to be used in this workflow! Hooked works by adding the hooks
into the repo and setting them to executable and linking them into the
hooks directory under .git. This means hooks get to travel with the
repo and are source controlled. All a dev needs to do is run the init
command and hooked will symlink them all for them. No need to remember
how ln works. It's all handled for you. Future work will iterate about
what hooks that dev-suite supplies as part of the script. This will
involve configuration files and per repo settings are something that
will need to be thought about.
Closes Issue #2
|
| |
|
|
|
|
|
|
|
|
| |
This cleans up the init function using the modified find_root function
for ticket and moves it into a new shared crate so that other tools that
might be built can use it. This means we can easily find the root of
a git repo no matter where in the repo one is and build paths relative
to it.
Closes #3
|
| | |
|
| |
|
