Fix PATH getting wiped on Windows during install

There was no variable expansion called for %PATH% in

	setx PATH <dev-suite>;%PATH%

effectively replacing PATH with litteraly `<dev-suite>;%PATH%`.

The fix is simple, the command just needs to be called inside a shell
with `cmd /C`.

1 files changed, 24 insertions, 0 deletions

diff --git a/.dev-suite/ticket/closed/ds-install-wipes-user-path-on-windows.toml b/.dev-suite/ticket/closed/ds-install-wipes-user-path-on-windows.toml
new file mode 100644
index 0000000..eb168e9
--- /dev/null
+++ b/.dev-suite/ticket/closed/ds-install-wipes-user-path-on-windows.toml
@@ -0,0 +1,24 @@
+title = 'ds install wipes user PATH on Windows'
+status = 'Closed'
+id = 'a2448280-2f41-11ea-b9b7-55d06c658ffe'
+assignees = []
+description = '''
+Currently on Windows, `ds install` calls the following command to add the folder
+containing downloaded dev-suite binaries to the PATH:
+
+```
+setx PATH <dev-suite location>;%PATH%
+```
+
+However this isn't called inside a shell, so variable expansion isn't performed,
+and the PATH the user had previously set is lost into oblivion.
+
+A simple fix is to call this instead:
+
+```
+cmd /C "setx PATH <dev-suite location>;%PATH%"
+```
+'''
+version = 'V1'
+
+[comments]