aboutsummaryrefslogtreecommitdiff
path: root/nixpkgs/pkgs/development/tools/gotools/default.nix
diff options
context:
space:
mode:
Diffstat (limited to 'nixpkgs/pkgs/development/tools/gotools/default.nix')
-rw-r--r--nixpkgs/pkgs/development/tools/gotools/default.nix20
1 files changed, 13 insertions, 7 deletions
diff --git a/nixpkgs/pkgs/development/tools/gotools/default.nix b/nixpkgs/pkgs/development/tools/gotools/default.nix
index a7858474a42..11926b3b0c6 100644
--- a/nixpkgs/pkgs/development/tools/gotools/default.nix
+++ b/nixpkgs/pkgs/development/tools/gotools/default.nix
@@ -11,18 +11,24 @@ buildGoModule rec {
sha256 = "0a8c7j4w784w441j3j3bh640vy1g6g214641qv485wyi0xj49anf";
};
- # Build of golang.org/x/tools/gopls fails with:
- # can't load package: package golang.org/x/tools/gopls: unknown import path "golang.org/x/tools/gopls": cannot find module providing package golang.org/x/tools/gopls
- # That is most probably caused by golang.org/x/tools/gopls containing a separate Go module.
- # In order to fix this, we simply remove the module.
- # Note that build of golang.org/x/tools/cmd/gopls provides identical binary as golang.org/x/tools/gopls.
- # See https://github.com/NixOS/nixpkgs/pull/64335.
+ # The gopls folder contains a Go submodule which causes a build failure.
+ # Given that, we can't have the gopls binary be part of the gotools
+ # derivation.
+ #
+ # The attribute "gopls" provides the gopls binary.
+ #
+ # Related
+ #
+ # * https://github.com/NixOS/nixpkgs/pull/85868
+ # * https://github.com/NixOS/nixpkgs/issues/88716
postPatch = ''
rm -rf gopls
'';
vendorSha256 = "0pplmqxrnc8qnr5708igx4dm7rb0hicvhg6lh5hj8zkx38nb19s0";
+ doCheck = false;
+
postConfigure = ''
# Make the builtin tools available here
mkdir -p $out/bin
@@ -47,4 +53,4 @@ buildGoModule rec {
# Do not copy this without a good reason for enabling
# In this case tools is heavily coupled with go itself and embeds paths.
allowGoReference = true;
-} \ No newline at end of file
+}