home-manager: minor news build cleanups

- Rename the build function.

- Specify the built attribute in the build function.

- Make the news build silent.

1 files changed, 11 insertions, 4 deletions

diff --git a/home-manager/home-manager b/home-manager/home-manager
index 4722d41a2f8..329dd8d5cbe 100644
--- a/home-manager/home-manager
+++ b/home-manager/home-manager
@@ -75,7 +75,7 @@ function doBuildAttr() {
 
 function presentNews() {
     local infoFile
-    infoFile=$(doBuildNews -A newsInfo) || return 1
+    infoFile=$(buildNews) || return 1
 
     # shellcheck source=/dev/null
     . "$infoFile"
@@ -170,8 +170,15 @@ function newsReadIdsFile() {
     echo "$path"
 }
 
-function doBuildNews() {
-    doBuildAttr "$*" \
+# Builds news meta information to be sourced into this script.
+#
+# Note, we suppress build output to remove unnecessary verbosity. We
+# also use "no out link" to avoid the need for a build directory
+# (although this exposes the risk of GC removing the result before we
+# manage to source it).
+function buildNews() {
+    doBuildAttr --quiet \
+                --attr newsInfo \
                 --no-out-link \
                 --arg check false \
                 --argstr newsReadIdsFile "$(newsReadIdsFile)"
@@ -179,7 +186,7 @@ function doBuildNews() {
 
 function doShowNews() {
     local infoFile
-    infoFile=$(doBuildNews -A newsInfo) || return 1
+    infoFile=$(buildNews) || return 1
 
     # shellcheck source=/dev/null
     . "$infoFile"