aboutsummaryrefslogtreecommitdiff
path: root/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin
diff options
context:
space:
mode:
authorMx Kookie <kookie@spacekookie.de>2020-10-31 19:35:09 +0100
committerMx Kookie <kookie@spacekookie.de>2020-10-31 19:35:09 +0100
commitc4625b175f8200f643fd6e11010932ea44c78433 (patch)
treebce3f89888c8ac3991fa5569a878a9eab6801ccc /infra/libkookie/nixpkgs/pkgs/development/libraries/gamin
parent49f735974dd103039ddc4cb576bb76555164a9e7 (diff)
parentd661aa56a8843e991261510c1bb28fdc2f6975ae (diff)
Add 'infra/libkookie/' from commit 'd661aa56a8843e991261510c1bb28fdc2f6975ae'
git-subtree-dir: infra/libkookie git-subtree-mainline: 49f735974dd103039ddc4cb576bb76555164a9e7 git-subtree-split: d661aa56a8843e991261510c1bb28fdc2f6975ae
Diffstat (limited to 'infra/libkookie/nixpkgs/pkgs/development/libraries/gamin')
-rw-r--r--infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/deadlock.patch68
-rw-r--r--infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/debian-patches.nix10
-rw-r--r--infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/debian-patches.txt2
-rw-r--r--infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/default.nix46
-rw-r--r--infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/returnval.patch12
5 files changed, 138 insertions, 0 deletions
diff --git a/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/deadlock.patch b/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/deadlock.patch
new file mode 100644
index 000000000000..e2abc8ce2d97
--- /dev/null
+++ b/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/deadlock.patch
@@ -0,0 +1,68 @@
+Fix for a deadlock:
+https://bugzilla.gnome.org/show_bug.cgi?id=667230
+
+From cc14440eface093548cb3bc7814da11d9a99d283 Mon Sep 17 00:00:00 2001
+From: Anssi Hannula <anssi@mageia.org>
+Date: Wed, 4 Jan 2012 00:23:55 +0200
+Subject: [PATCH] fix possible server deadlock in ih_sub_cancel
+
+ih_sub_foreach() calls ih_sub_cancel() while inotify_lock is locked.
+However, ih_sub_cancel() locks it again, and locking GMutex recursively
+causes undefined behaviour.
+
+Fix that by removing locking from ih_sub_cancel() as ih_sub_foreach()
+is its only user. Also make the function static so that it won't
+accidentally get used by other files without locking (inotify-helper.h
+is an internal server header).
+
+This should fix the intermittent deadlocks I've been experiencing
+causing KDE applications to no longer start, and probably also
+http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=542361
+---
+ server/inotify-helper.c | 7 ++-----
+ server/inotify-helper.h | 1 -
+ 2 files changed, 2 insertions(+), 6 deletions(-)
+
+diff --git a/server/inotify-helper.c b/server/inotify-helper.c
+index d77203e..0789fa4 100644
+--- a/server/inotify-helper.c
++++ b/server/inotify-helper.c
+@@ -123,13 +123,11 @@ ih_sub_add (ih_sub_t * sub)
+
+ /**
+ * Cancels a subscription which was being monitored.
++ * inotify_lock must be held when calling.
+ */
+-gboolean
++static gboolean
+ ih_sub_cancel (ih_sub_t * sub)
+ {
+- G_LOCK(inotify_lock);
+-
+-
+ if (!sub->cancelled)
+ {
+ IH_W("cancelling %s\n", sub->pathname);
+@@ -140,7 +138,6 @@ ih_sub_cancel (ih_sub_t * sub)
+ sub_list = g_list_remove (sub_list, sub);
+ }
+
+- G_UNLOCK(inotify_lock);
+ return TRUE;
+ }
+
+diff --git a/server/inotify-helper.h b/server/inotify-helper.h
+index 5d3b6d0..d36b5fd 100644
+--- a/server/inotify-helper.h
++++ b/server/inotify-helper.h
+@@ -34,7 +34,6 @@ gboolean ih_startup (event_callback_t ecb,
+ found_callback_t fcb);
+ gboolean ih_running (void);
+ gboolean ih_sub_add (ih_sub_t *sub);
+-gboolean ih_sub_cancel (ih_sub_t *sub);
+
+ /* Return FALSE from 'f' if the subscription should be cancelled */
+ void ih_sub_foreach (void *callerdata, gboolean (*f)(ih_sub_t *sub, void *callerdata));
+--
+1.7.7.2
+
diff --git a/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/debian-patches.nix b/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/debian-patches.nix
new file mode 100644
index 000000000000..a8f334fb3c39
--- /dev/null
+++ b/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/debian-patches.nix
@@ -0,0 +1,10 @@
+# Generated by debian-patches.sh from debian-patches.txt
+let
+ prefix = "https://sources.debian.org/data/main/g/gamin/0.1.10-4.1/debian/patches";
+in
+[
+ {
+ url = "${prefix}/17_deprecated_const_return.patch";
+ sha256 = "0bssrqcmyivlpk2g0q71d1yavd4wv1lw34l8qipm0ndljjd6rbrk";
+ }
+]
diff --git a/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/debian-patches.txt b/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/debian-patches.txt
new file mode 100644
index 000000000000..46d2420b21ed
--- /dev/null
+++ b/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/debian-patches.txt
@@ -0,0 +1,2 @@
+gamin/0.1.10-4.1
+17_deprecated_const_return.patch
diff --git a/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/default.nix b/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/default.nix
new file mode 100644
index 000000000000..38451571d8b6
--- /dev/null
+++ b/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/default.nix
@@ -0,0 +1,46 @@
+{ stdenv, fetchurl, fetchpatch, pkgconfig, glib }:
+
+stdenv.mkDerivation (rec {
+ name = "gamin-0.1.10";
+
+ src = fetchurl {
+ url = "https://www.gnome.org/~veillard/gamin/sources/${name}.tar.gz";
+ sha256 = "18cr51y5qacvs2fc2p1bqv32rs8bzgs6l67zhasyl45yx055y218";
+ };
+
+ nativeBuildInputs = [ pkgconfig ];
+
+ buildInputs = [ glib ];
+
+ # `_GNU_SOURCE' is needed, e.g., to get `struct ucred' from
+ # <sys/socket.h> with Glibc 2.9.
+ configureFlags = [
+ "--disable-debug"
+ "--without-python" # python3 not supported
+ "CPPFLAGS=-D_GNU_SOURCE"
+ ];
+
+ patches = [ ./deadlock.patch ]
+ ++ map fetchurl (import ./debian-patches.nix)
+ ++ stdenv.lib.optional stdenv.cc.isClang ./returnval.patch
+ ++ stdenv.lib.optional stdenv.hostPlatform.isMusl (fetchpatch {
+ name = "fix-pthread-mutex.patch";
+ url = "https://git.alpinelinux.org/aports/plain/main/gamin/fix-pthread-mutex.patch?h=3.4-stable&id=a1a836b089573752c1b0da7d144c0948b04e8ea8";
+ sha256 = "13igdbqsxb3sz0h417k6ifmq2n4siwqspj6slhc7fdl5wd1fxmdz";
+ });
+
+
+ meta = with stdenv.lib; {
+ homepage = "https://people.gnome.org/~veillard/gamin/";
+ description = "A file and directory monitoring system";
+ maintainers = with maintainers; [ lovek323 ];
+ license = licenses.gpl2;
+ platforms = platforms.unix;
+ };
+}
+
+// stdenv.lib.optionalAttrs stdenv.isDarwin {
+ preBuild = ''
+ sed -i 's/,--version-script=.*$/\\/' libgamin/Makefile
+ '';
+})
diff --git a/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/returnval.patch b/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/returnval.patch
new file mode 100644
index 000000000000..3944b14be64c
--- /dev/null
+++ b/infra/libkookie/nixpkgs/pkgs/development/libraries/gamin/returnval.patch
@@ -0,0 +1,12 @@
+diff -rupN gamin-0.1.10-orig/server/gam_eq.c gamin-0.1.10/server/gam_eq.c
+--- gamin-0.1.10-orig/server/gam_eq.c 2015-04-05 19:25:54.000000000 -0400
++++ gamin-0.1.10/server/gam_eq.c 2015-04-05 19:26:00.000000000 -0400
+@@ -124,7 +124,7 @@ gam_eq_flush (gam_eq_t *eq, GamConnDataP
+ {
+ gboolean done_work = FALSE;
+ if (!eq)
+- return;
++ return done_work;
+
+ #ifdef GAM_EQ_VERBOSE
+ GAM_DEBUG(DEBUG_INFO, "gam_eq: Flushing event queue for %s\n", gam_connection_get_pidname (conn));