From 2ff7c3e2e1982fd3db4f8f7725143f0645682a54 Mon Sep 17 00:00:00 2001 From: Silvan Mosberger Date: Wed, 16 Sep 2020 20:03:40 +0200 Subject: lib/types: Remove unreachable if branch The type's check function already ensured that it can't be passed non-lists --- lib/types.nix | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) (limited to 'lib/types.nix') diff --git a/lib/types.nix b/lib/types.nix index aae45366b8fb..77105740bc23 100644 --- a/lib/types.nix +++ b/lib/types.nix @@ -299,16 +299,14 @@ rec { check = isList; merge = loc: defs: map (x: x.value) (filter (x: x ? value) (concatLists (imap1 (n: def: - if isList def.value then - imap1 (m: def': - (mergeDefinitions - (loc ++ ["[definition ${toString n}-entry ${toString m}]"]) - elemType - [{ inherit (def) file; value = def'; }] - ).optionalValue - ) def.value - else - throw "The option value `${showOption loc}` in `${def.file}` is not a list.") defs))); + imap1 (m: def': + (mergeDefinitions + (loc ++ ["[definition ${toString n}-entry ${toString m}]"]) + elemType + [{ inherit (def) file; value = def'; }] + ).optionalValue + ) def.value + ) defs))); emptyValue = { value = {}; }; getSubOptions = prefix: elemType.getSubOptions (prefix ++ ["*"]); getSubModules = elemType.getSubModules; -- cgit v1.2.3